Support unambiguous detection of language if only prefixes are supplied #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejcik
reviewed
Nov 29, 2022
Closed
o ceases search as soon as ambiguity is resolved
pjkundert
force-pushed
the
feature-language-prefixes
branch
from
48ccd87 to
07a4be4
Compare
|
Hi, @matejcik -- sorry for not bringing this up-to-date earlier! It should now be ready for the next release. Thanks! |
|
Turns out supporting prefixes in language deduction was more complex than I though... The present implementation correctly resolves ambiguity, by requiring exactly one language to match word(s) fully, if all words are prefixes in multiple languages. Only completely unambiguous codes pass language deduction. |
pjkundert
force-pushed
the
feature-language-prefixes
branch
from
01393e4 to
cf7df0a
Compare
|
merged as 4b14fc5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a BIP-39 Mnemonic is supplied that contains word prefixes (such as would be resolved by calling Mnemonic.expand), the Mnemonic.detect_language function fails. This fix simply allows detect_language to proceed until the prefix no longer appears in multiple language dictionaries.
Also, we detect that ambiguity no longer exists (less than 2 languages remain), and we suspend t the search.
Tests added to confirm that the search proceeds in the face of prefixes available in multiple languages.